-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken links in docs #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Karan's OOO this week so I'll take over the review) Just one minor tweak, otherwise LGTM. Thanks for these fixes!
I'm fixing CI for forked PRs here, #9 (Github Actions doesn't allow usage of repo secrets for CI running on forked PRs, but since all dependencies are open sourced now we can fully remove this configuration) Update against |
Co-authored-by: Harvey Xia <[email protected]>
Thanks for the review! I've applied the suggestions and updated against |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for this contribution
💸 TL;DR
Updates links that pointed to non-public resources
📜 Details
After attending yesterday's (awesome) KubeCon session about this library, I started combing through the docs but kept hitting broken or private links. I've therefore attempted to update those links in this PR to the best location I could determine.
Please double-check my changes here (especially in the
sdk-fsm-reconciler.md
file) since I haven't actually used this library yet and don't want to mislead other developers by pointing to the wrong places! 😅🧪 Testing Steps / Validation
I manually clicked the updated links to ensure they loaded?
✅ Checks