Skip to content

Commit

Permalink
upgrade(actions): upgrade checkout and setup-python (#788)
Browse files Browse the repository at this point in the history
GitHub deprecated Node 12 to Node 16. The current versions of checkout and setup-python GitHub actions depend on a depricated version of Node.

I cut a release as a test [here](https://github.com/reddit/baseplate.py/actions/runs/4985027857), the build failed because of a bad tag, but did run. [Here](https://github.com/reddit/baseplate.py/actions/runs/4963056617) is the previous failure.

This also upgrades pins the version of requests being used during build time, this is necessary for the package to be successfully uploaded.

#787 applies this change to the gcp build.
  • Loading branch information
KTAtkinson authored and praxist committed Nov 29, 2023
1 parent 61a2642 commit 5683a51
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/python-publish.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,17 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Set up Python
uses: actions/setup-python@v2
uses: actions/setup-python@v3
with:
python-version: '3.8'

- name: Install dependencies
run: |
python -m pip install --upgrade pip
python -m pip install setuptools==47.3.0 wheel==0.34.2 twine==3.1.1
python -m pip install setuptools==47.3.0 wheel==0.34.2 twine==3.1.1 requests==2.29.0
- name: Build and publish
env:
Expand Down

0 comments on commit 5683a51

Please sign in to comment.