-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add queue flushing signal handler #792
Open
atai92
wants to merge
9
commits into
reddit:develop
Choose a base branch
from
atai92:add_queue_flushing_signal_handler
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ccad13a
Added flush queue signal handler within event publisher.
9c7ec10
Linting and formatting.
0c71eba
Updating is_ready to simply return the result of the condition
1e974ab
Merge branch 'develop' into add_queue_flushing_signal_handler
KTAtkinson 6b3828c
Updating to use try add batcher msg instead of checking whether the p…
017b538
Removing property for is_full since it is not useful anymore.
75b13c2
Adding missing batcher.add(message) after publishing batch, so we don…
fec5c07
Lint.
cb60ac6
Merge branch 'develop' into add_queue_flushing_signal_handler
atai92 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The length here will always be greater than
0
because we add a header. We might want to add aitems_count
function to the batcher to count the number of items currently in the queue. It could use the length of batcher._items.