Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explict setting for APP vs PAT auth #29

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

danfoster
Copy link

Description

I don't want the helm chart to manage the secret with PAT/APP details, because I manage secrets via sealedSecrets.
In theory this is fine, as I can just leave githubPat and githubApp* values blanks and the chart won't create the secret and I can just refer to an existing secret.

But the condition if to include the GITHUB_APP* or GITHUB_PAT env vars in the Deployment is conditional on one of these being set. So this makes it impossible to include the env vars without it also managing the secret.

The approach I've taken here is to create a new value: authType, which is either app or pat. This is used to decide which env vars to expose. This allows us to expose an externally managed secret for either.

But this will be a breaking change, as every user will need to set this value. Not sure if there's a better way to manage this?

Related Issue(s)

Checklist

  • This PR includes a documentation change
  • This PR does not need a documentation change

  • This PR includes test changes
  • This PR's changes are already tested

  • This change is not user-facing
  • This change is a patch change
  • This change is a minor change
  • This change is a major (breaking) change

Changes made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant