Add explict setting for APP vs PAT auth #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I don't want the helm chart to manage the secret with PAT/APP details, because I manage secrets via sealedSecrets.
In theory this is fine, as I can just leave
githubPat
andgithubApp*
values blanks and the chart won't create the secret and I can just refer to an existing secret.But the condition if to include the GITHUB_APP* or GITHUB_PAT env vars in the Deployment is conditional on one of these being set. So this makes it impossible to include the env vars without it also managing the secret.
The approach I've taken here is to create a new value:
authType
, which is eitherapp
orpat
. This is used to decide which env vars to expose. This allows us to expose an externally managed secret for either.But this will be a breaking change, as every user will need to set this value. Not sure if there's a better way to manage this?
Related Issue(s)
Checklist
Changes made