Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync workflow: send PR instead of pushing to main #43

Merged

Conversation

chmeliik
Copy link
Member

By pushing directly to main, build-definitions syncs would bypass CI
checks.

Not to mention the main branch is protected, so this workflow can't
push directly to main.

@openshift-ci openshift-ci bot requested review from flacatus and mmorhun July 25, 2024 11:32
@chmeliik chmeliik marked this pull request as draft July 25, 2024 11:50
@chmeliik
Copy link
Member Author

Still testing the changes. At the very least, I need someone who has the permissions to go to https://github.com/redhat-appstudio/tssc-sample-pipelines/settings/actions and enable Allow GitHub Actions to create and approve pull requests

@chmeliik chmeliik force-pushed the fix-builddefs-import branch 6 times, most recently from 3ad1909 to c77b336 Compare July 25, 2024 15:18
By pushing directly to main, build-definitions syncs would bypass CI
checks.

Not to mention the main branch is protected, so this workflow *can't*
push directly to main.

Signed-off-by: Adam Cmiel <[email protected]>
@chmeliik chmeliik force-pushed the fix-builddefs-import branch from c77b336 to 98bcf7e Compare July 25, 2024 15:18
@chmeliik
Copy link
Member Author

chmeliik commented Jul 25, 2024

Ok, tested in chmeliik#1, should work 🤞

The reason why it was failing here is that I opened the PR from my fork, so GitHub wouldn't give the automatically injected GITHUB_TOKEN write permissions for branches and pull requests. Once merged, the workflow will run from this PR so the token should receive the permissions the workflow requests.

But it's importing things we don't want, because the RHTAP pipeline in build-definitions picked up unwanted changes (again). Fixing in konflux-ci/build-definitions#1196

@chmeliik chmeliik marked this pull request as ready for review July 26, 2024 07:56
@chmeliik
Copy link
Member Author

/retest

@openshift-ci openshift-ci bot requested review from prietyc123 and xinredhat July 26, 2024 07:56
@chmeliik
Copy link
Member Author

Ready for review

Copy link

openshift-ci bot commented Jul 26, 2024

@chmeliik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rhtap-sample-pipelines-yamllint 98bcf7e link false /test rhtap-sample-pipelines-yamllint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@chmeliik
Copy link
Member Author

yamllint issues are unrelated to this PR

Copy link

openshift-ci bot commented Jul 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmeliik, mmorhun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit de9499f into redhat-appstudio:main Jul 29, 2024
2 of 3 checks passed
@chmeliik chmeliik deleted the fix-builddefs-import branch August 21, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants