-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync workflow: send PR instead of pushing to main #43
sync workflow: send PR instead of pushing to main #43
Conversation
Still testing the changes. At the very least, I need someone who has the permissions to go to https://github.com/redhat-appstudio/tssc-sample-pipelines/settings/actions and enable |
3ad1909
to
c77b336
Compare
By pushing directly to main, build-definitions syncs would bypass CI checks. Not to mention the main branch is protected, so this workflow *can't* push directly to main. Signed-off-by: Adam Cmiel <[email protected]>
c77b336
to
98bcf7e
Compare
Ok, tested in chmeliik#1, should work 🤞 The reason why it was failing here is that I opened the PR from my fork, so GitHub wouldn't give the automatically injected GITHUB_TOKEN write permissions for branches and pull requests. Once merged, the workflow will run from this PR so the token should receive the permissions the workflow requests. But it's importing things we don't want, because the RHTAP pipeline in build-definitions picked up unwanted changes (again). Fixing in konflux-ci/build-definitions#1196 |
/retest |
Ready for review |
@chmeliik: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
yamllint issues are unrelated to this PR |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chmeliik, mmorhun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
de9499f
into
redhat-appstudio:main
By pushing directly to main, build-definitions syncs would bypass CI
checks.
Not to mention the main branch is protected, so this workflow can't
push directly to main.