Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quarkus-cafe-demo demo workload #2143

Closed
wants to merge 0 commits into from

Conversation

tosin2013
Copy link
Contributor

SUMMARY

This pull request is for the quarkus-cafe-demo demo workload #2142 feature request. The Quarkus Cafe demo is an event-driven demo application built with Quarkus, AMQ Streams (Kafka), and MongoDB. The application can run locally and in OpenShift (Kubernetes.) That we would like to run on RHPDS.

ISSUE TYPE
  • New role Pull Request
COMPONENT NAME

ocp-workload-quarkus-cafe-demo-role

TARGET_HOST="bastion.dev.openshift.opentlc.com"
OCP_USERNAME="openshiftuser"
ANSIBLE_USER="ec2-user"
WORKLOAD="ocp-workload-quarkus-cafe-demo-role"
GUID=1001
SSH_KEYNAME=sshkeyname.pem

Finally run the workload passing the input files as parameters:

# a TARGET_HOST is specified in the command line, without using an inventory file
ansible-playbook -i ${TARGET_HOST}, ./configs/ocp-workloads/ocp-workload.yml \
                 -e"ansible_ssh_private_key_file=/home/${ANSIBLE_USER}/.ssh/${SSH_KEYNAME}" \
                 -e"ansible_user=${ANSIBLE_USER}" \
                 -e"ocp_username=${OCP_USERNAME}" \
                 -e"ocp_workload=${WORKLOAD}" \
                 -e"guid=${GUID}" \
                 -e"ocp_user_needs_quota=true" \
                 -e"domain=cluster-${GUID}.${GUID}.example.opentlc.com" \
                 -e"ACTION=create"
ADDITIONAL INFORMATION
  1. I do plan on using ansiblek8 in this role. I am currently not using that.

Copy link
Collaborator

@stencell stencell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple things.

I stopped making individual comments because there are so many. Please replace any shell or command modules with k8s or k8s_info. I know there are a couple that you are doing things like oc new-app or oc start build and those are okay...but the rest can all use the modules.

Also, please rename this role. I am assuming this is meant for ocp4, so call it ocp4_workload_quarkus_cafe_demo and move it to the roles_ocp_workloads folder.

@tosin2013
Copy link
Contributor Author

tosin2013 commented Jul 28, 2020 via email

@tosin2013 tosin2013 requested a review from stencell July 30, 2020 17:57
@fridim
Copy link
Collaborator

fridim commented Sep 9, 2020

@tosin2013 any update on this Pull Request ?

@tosin2013
Copy link
Contributor Author

@tosin2013 any update on this Pull Request ?

I made the requested changes to the code. I was waiting for someone to review the pull request.

@darbyredhat
Copy link
Contributor

@tosin2013 - Hi Tosin,

I'm Chád Darby, a member of the GPTE team. Nate requested that I perform a code review of your PR from a Quarkus dev perspective.

Would you be avail later this week for a BJ call to review the code? Basically a 30 min time slot where you can give me an overview of your project. I'm avail Thurs or Friday this week. Let me know what works best for you. My Google calendar is up to date. You can send me a Google calendar invite.

@darbyredhat
Copy link
Contributor

darbyredhat commented Oct 28, 2020

I reviewed this PR from a Quarkus dev perspective. This looks good to me. Please proceed.

@stencell
Copy link
Collaborator

@tosin2013 This has a travis error: https://travis-ci.org/github/redhat-cop/agnosticd/builds/731410679. You might be able to fix this by merging or rebasing to development since this is quite a bit behind. Shouldn't be a problem for this workload since it is net-new.

@tosin2013 tosin2013 requested a review from a team as a code owner December 2, 2021 19:26
@tosin2013 tosin2013 closed this Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants