-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quarkus-cafe-demo demo workload #2143
Conversation
ansible/roles/ocp-workload-quarkus-cafe-demo-role/defaults/main.yml
Outdated
Show resolved
Hide resolved
ansible/roles/ocp-workload-quarkus-cafe-demo-role/defaults/main.yml
Outdated
Show resolved
Hide resolved
ansible/roles/ocp-workload-quarkus-cafe-demo-role/tasks/amq-streams-install.yml
Outdated
Show resolved
Hide resolved
ansible/roles/ocp-workload-quarkus-cafe-demo-role/tasks/amq-streams-install.yml
Outdated
Show resolved
Hide resolved
ansible/roles/ocp-workload-quarkus-cafe-demo-role/tasks/amq-streams-install.yml
Outdated
Show resolved
Hide resolved
ansible/roles/ocp-workload-quarkus-cafe-demo-role/tasks/amq-streams-install.yml
Outdated
Show resolved
Hide resolved
ansible/roles/ocp-workload-quarkus-cafe-demo-role/tasks/amq-streams-install.yml
Outdated
Show resolved
Hide resolved
ansible/roles/ocp-workload-quarkus-cafe-demo-role/tasks/quarkus-cafe-barista.yml
Outdated
Show resolved
Hide resolved
ansible/roles/ocp-workload-quarkus-cafe-demo-role/tasks/quarkus-cafe-barista.yml
Outdated
Show resolved
Hide resolved
ansible/roles/ocp-workload-quarkus-cafe-demo-role/tasks/quarkus-cafe-barista.yml
Outdated
Show resolved
Hide resolved
ansible/roles/ocp-workload-quarkus-cafe-demo-role/tasks/quarkus-cafe-core.yaml
Outdated
Show resolved
Hide resolved
ansible/roles/ocp-workload-quarkus-cafe-demo-role/tasks/quarkus-cafe-core.yaml
Outdated
Show resolved
Hide resolved
ansible/roles/ocp-workload-quarkus-cafe-demo-role/tasks/quarkus-cafe-core.yaml
Outdated
Show resolved
Hide resolved
ansible/roles/ocp-workload-quarkus-cafe-demo-role/tasks/quarkus-cafe-core.yaml
Outdated
Show resolved
Hide resolved
ansible/roles/ocp-workload-quarkus-cafe-demo-role/tasks/quarkus-cafe-core.yaml
Outdated
Show resolved
Hide resolved
ansible/roles/ocp-workload-quarkus-cafe-demo-role/tasks/quarkus-cafe-customermock.yaml
Outdated
Show resolved
Hide resolved
ansible/roles/ocp-workload-quarkus-cafe-demo-role/tasks/quarkus-cafe-customermock.yaml
Outdated
Show resolved
Hide resolved
ansible/roles/ocp-workload-quarkus-cafe-demo-role/tasks/quarkus-cafe-customermock.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple things.
I stopped making individual comments because there are so many. Please replace any shell
or command
modules with k8s
or k8s_info
. I know there are a couple that you are doing things like oc new-app
or oc start build
and those are okay...but the rest can all use the modules.
Also, please rename this role. I am assuming this is meant for ocp4, so call it ocp4_workload_quarkus_cafe_demo
and move it to the roles_ocp_workloads
folder.
Ok, I will work on that.
…On Mon, Jul 27, 2020 at 2:35 AM Nate Stephany ***@***.***> wrote:
***@***.**** requested changes on this pull request.
A couple things.
I stopped making individual comments because there are so many. Please
replace any shell or command modules with k8s or k8s_info. I know there
are a couple that you are doing things like oc new-app or oc start build
and those are okay...but the rest can all use the modules.
Also, please rename this role. I am assuming this is meant for ocp4, so
call it ocp4_workload_quarkus_cafe_demo and move it to the
roles_ocp_workloads folder.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2143 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPCKL7YGQ47S5ZGA6BGLWDR5UN2ZANCNFSM4OUWD6TQ>
.
--
<[email protected]>
[image: AWS Certified SysOps Administrator - Associate]
|
@tosin2013 any update on this Pull Request ? |
I made the requested changes to the code. I was waiting for someone to review the pull request. |
@tosin2013 - Hi Tosin, I'm Chád Darby, a member of the GPTE team. Nate requested that I perform a code review of your PR from a Quarkus dev perspective. Would you be avail later this week for a BJ call to review the code? Basically a 30 min time slot where you can give me an overview of your project. I'm avail Thurs or Friday this week. Let me know what works best for you. My Google calendar is up to date. You can send me a Google calendar invite. |
I reviewed this PR from a Quarkus dev perspective. This looks good to me. Please proceed. |
@tosin2013 This has a travis error: https://travis-ci.org/github/redhat-cop/agnosticd/builds/731410679. You might be able to fix this by merging or rebasing to development since this is quite a bit behind. Shouldn't be a problem for this workload since it is net-new. |
e147dcb
to
e7ec138
Compare
SUMMARY
This pull request is for the quarkus-cafe-demo demo workload #2142 feature request. The Quarkus Cafe demo is an event-driven demo application built with Quarkus, AMQ Streams (Kafka), and MongoDB. The application can run locally and in OpenShift (Kubernetes.) That we would like to run on RHPDS.
ISSUE TYPE
COMPONENT NAME
ocp-workload-quarkus-cafe-demo-role
Finally run the workload passing the input files as parameters:
ADDITIONAL INFORMATION