This repository has been archived by the owner on Nov 20, 2023. It is now read-only.
Added python-ovirt-engine-sdk4 to casl-origin Dockerfile #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oybed
reviewed
Feb 13, 2019
| @@ -4,10 +4,13 @@ USER root | |||
|
|
|||
| # Update System and install clients | |||
| RUN \ | |||
| yum install -y --setopt=tsflags=nodocs https://repos.fedorapeople.org/repos/openstack/openstack-queens/rdo-release-queens-1.noarch.rpm; \ | |||
| yum install -y --setopt=tsflags=nodocs \ | |||
| https://repos.fedorapeople.org/repos/openstack/openstack-queens/rdo-release-queens-1.noarch.rpm \ | |||
There was a problem hiding this comment.
nitpick - for readability, can you please indent the file names as these aren't commands ... in that way, we have the commands (such as yum, pip, etc. at the same level) - just like below for the python-* packages.
There was a problem hiding this comment.
@jeffcpullen If you can get this one done, we can merge. Thank you.
|
@oybed ; can this be closed? looks like another PR was raised. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In order to add RHV as a provider we need the casl-ansible docker image to contain the necessary ovirt SDK to interact with the APIs. This PR updates the Dockerfile to add a repo and rpm that accomplishes that.
How should this be manually tested?
This has been tested to build properly with the following commands
Is there a relevant Issue open for this?
resolves #342
Other Relevant info, PRs, etc.
This is a pre-req for future PRs related to adding the RHV provider
Who would you like to review this?
cc: @redhat-cop/casl