This repository has been archived by the owner on Nov 20, 2023. It is now read-only.
libvirt postinstall (final step 4/4) #356
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* WIP: Provisioning an OpenShift Cluster on Libvirt * remove symlink * remove test user from ks files * remove yml file * edit inventry file * modify the host_vars * edit ks file path file * modify inventory and playbook
stopped VMs are silently ignored, works with Python3, add environment variables to configure script in regard to connection uri, VMs filtering and variables prefix in inventory.
…al network used. This makes it easier to avoid collisions with already existing networks. The playbook `provision.yml` runs through and 3 hosts are created but there is more to do in terms of storage and DNS/network setup to make it workable for OpenShift is my strong assumption.
… in CONTRIBUTE_PROVISIONER.md
oreg variables to pull the OpenShift images. ignore memory and disk space checks.
Add openshift_authorized_key_file parameter to be used instead of _url Adapt accordingly sync-keys role Add this variable to Libvirt inventory and split properly between OCP and non-OCP variables
…ture todos for libvirt
Name of package is valid also for Python3 Use loop/range instead of with_sequence
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implementation of the Libvirt provisioner, it's still not perfect but it would be good to have it reviewed and merged so that more than one person can work on the topic. And also have someone with more OpenShift knowledge look at it and make recommendations would help a lot.
How should this be manually tested?
Follow the instructions of docs/PROVISIONING_LIBVIRT.adoc from top to bottom
Is there a relevant Issue open for this?
n/a
Other Relevant info, PRs, etc.
If I understand correctly how Git(Hub) works, I guess that the steps 1 to 3 can be ignored/closed once this PR is merged into master, I still created them one for each step as it can make review easier (but fill free to ask as you see best fit): #352 #353 #354
Who would you like to review this?
cc: @redhat-cop/casl