Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mm feature/fix export vm as ovf vars #105

Merged

Conversation

mikemorency
Copy link
Collaborator

This change is from the testathon feedback.

It includes two issues:

  1. The documentation for the export_vm_as_ovf role had duplicate and unused variables defined
  2. The role uses a _name suffix on the datacenter variable that is inconsistent with other roles.

I updated the docs and changed the variable to match other roles, while keeping the old variable name valid

Copy link
Collaborator

@anna-savina anna-savina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bardielle bardielle merged commit 633094a into redhat-cop:main Oct 9, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants