Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use collection and environment variables as fallbacks for common auth vars across all roles #108

Conversation

mikemorency
Copy link
Collaborator

This is feedback from the testathon.

Each role uses a similar set of authentication variables for things like vcenter hostname, username etc. Instead of requiring users to set these variables for all roles individually, it was recommended we have a centralized option.

This change allows people to set a collection level variable or an environment variable to set authentication options for everything. If the user needs to set a value for a specific role, they can still do that. The role variables take the highest priority

Copy link
Contributor

@bardielle bardielle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the integration tests to use the new env vars

@mikemorency mikemorency merged commit 73e061f into redhat-cop:main Oct 15, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants