Bugfix/info datacenters in documentation #118
Open
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrrBG
requested review from
bardielle,
machacekondra and
mikemorency
as code owners
mikemorency
approved these changes
Dec 23, 2024
roles/info/README.md
Outdated
| @@ -155,6 +155,10 @@ An abbreviated example of the data returned can be found below: | |||
| - File where to store the gathered data. Default is `/tmp/vmware_ops_info_cluster` | |||
| - If set to an empty string, the data is not written to a file. | |||
|
|
|||
| - **info_datacenters** (list(str)) | |||
| - A list of datacenter names used to specify the clusters for which to gather information. | |||
| - If this variable is not set, information on all vSphere vCenter clusters is gathered (TODO: is this correct?) | |||
There was a problem hiding this comment.
your right but the phrasing is a little confusing. maybe like
"A list of datacenter names that will be searched when gathering information about clusters."
"If this variable is not set, information on all vSphere vCenter clusters in all datacenters is gathered"
|
please wait for anna before merging |
anna-savina
reviewed
Dec 24, 2024
| @@ -0,0 +1,3 @@ | |||
| --- | |||
There was a problem hiding this comment.
I think this file should be added to "changelogs/fragments/", not to "changelogs" itself.
There was a problem hiding this comment.
also missing the .yml extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.