Add variable to handle NTP server #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvaldez
requested review from
bardielle,
machacekondra and
mikemorency
as code owners
mikemorency
approved these changes
Aug 16, 2024
| @@ -81,6 +81,9 @@ pyvomi | |||
| - **provision_vcenter_vm_network_dns**: | |||
| - list(str), A list of DNS servers the vcenter vm should use. Required if network mode is set to 'static'. | |||
|
|
|||
| - **provision_vcenter_vm_ntp_server**: | |||
| - str or int, Server to use for NTP source. | |||
There was a problem hiding this comment.
is int for IPs, or is there another way to specify the NTP servers besides hostname/IP?
There was a problem hiding this comment.
Yes just for pure IPs if used. I was just copying what was done for the other IP vars. It probably should only be str.
bardielle
approved these changes
Aug 18, 2024
|
@vvaldez thank you for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
provision_vcenter_vm_ntp_servervar and set default totime.nist.gov