Update ee builder to generate controller config #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-m-sullivan
force-pushed
the
main
branch
10 times, most recently
from
8e44c6c to
8bad0ab
Compare
sean-m-sullivan
changed the title
sean-m-sullivan
force-pushed
the
main
branch
4 times, most recently
from
2b91403 to
473350d
Compare
sean-m-sullivan
force-pushed
the
main
branch
from
473350d to
ddb75ff
Compare
|
@anshulbehl love to get your input on changes |
Tompage1994
requested changes
Nov 29, 2022
|
@Tompage1994 I am working on a Blog post and entire Repo to do exactly that, I figured we would add links in the Readme once I get it done. That is what prompted this. |
Tompage1994
approved these changes
Nov 29, 2022
|
@sean-m-sullivan Ok, based on that I'll accept this and I've raised #35 and assigned to you to add when you're ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update EE builder to generate controller configuration so it can more easily push updated Ee's to a registery. The user is free to then override this or ignore it.
Updated readme's and worked to make the definition of images more definite, clear, and working.
How should this be tested?
Automated tests but this has been tested.
Is there a relevant Issue open for this?
#33