Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use openshift client image from redhat registry for node-labeler job #246

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

dlbewley
Copy link
Contributor

@dlbewley dlbewley commented Oct 9, 2023

Use the OpenShift client image from Red Hat registry rather than assuming the local cluster registry has already been deployed with an alternative storage back end.

Copy link
Collaborator

@pittar pittar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I see your point @dlbewley , your change now assumes clusters have access to the Red Hat registry.
I'm ok with this change for now, but perhaps we should add an overlay for the internal registry as well.

@dlbewley
Copy link
Contributor Author

Fair, but if the cluster is disconnected (without access to Red Hat registry), there will have been accommodations made to mirror the RH registry or to proxy the pulls from it in order to install the cluster.

This automation exists to facilitate storage which in on-prem cases is very likely prerequisite to an internal registry. See also #233

@pittar pittar merged commit 8fda191 into redhat-cop:main Oct 10, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants