update: cert-manager #265
update: cert-manager #265
Conversation
codekow
requested review from
strangiato,
gnunn1,
pittar and
adetalhouet
as code owners
| apiVersion: kustomize.config.k8s.io/v1beta1 | ||
| kind: Kustomization | ||
|
|
||
| namespace: cert-manager-operator |
There was a problem hiding this comment.
Generally I prefer to keep the namespace in the kustomize, especially when you are dealing with multiple objects.
There was a problem hiding this comment.
I think most operators in the catalog use this pattern. Can we do this as a separate PR?
| @@ -1,9 +1,8 @@ | |||
| apiVersion: operators.coreos.com/v1 | |||
| kind: OperatorGroup | |||
| metadata: | |||
| name: cert-manager-operator | |||
| name: openshift-cert-manager-operator-group | |||
There was a problem hiding this comment.
I don't think it is a requirement, but I think normally the operator groups name is the same as the namespace. I would prefer to keep it the same as whatever the GUI creates when installing through the UI so if someone installs via the UI and then later adds the catalog item into gitops, it doesn't cause a second operator group to be created.
Can you confirm what the correct operatorgroup name should be?
There was a problem hiding this comment.
I agree with aligning the name of the operator group with the packagemanifest name, that might also be the namespace name... Either way we can remove the -group because it's redundant. This should be removed globally and in the script used to generate operators. I can do that in another PR.
There was a problem hiding this comment.
I think this was an exception with naming of things. We can dig into it more.
| @@ -1,9 +1,8 @@ | |||
| apiVersion: operators.coreos.com/v1 | |||
| kind: OperatorGroup | |||
| metadata: | |||
| name: cert-manager-operator | |||
| name: openshift-cert-manager-operator-group | |||
There was a problem hiding this comment.
I think this was an exception with naming of things. We can dig into it more.
|
@strangiato We good to merge this? |
|
@strangiato ... bump :) |
No description provided.