Enhance openshift-cert-manager-operator #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rmgrimm
commented
Aug 20, 2024
rmgrimm
commented
- Add additional channels (v1.12 thru v1.14)
- Rename letsencrypt route53 to include "cluster-issuer" to be more precise
- Add example for letsencrypt with HTTP01 solvers
- Add example for self-signed CA cluster issuer
- Add example for self-signed namespaced issuer
* Add additional channels (v1.12 thru v1.14) * Rename letsencrypt route53 to include "cluster-issuer" to be more precise * Add example for letsencrypt with HTTP01 solvers * Add example for self-signed CA cluster issuer * Add example for self-signed namespaced issuer
rmgrimm
requested review from
strangiato,
gnunn1,
pittar and
adetalhouet
as code owners
pittar
approved these changes
Aug 22, 2024
|
Lint won't re-run properly on this PR. It'll work on the next one. So, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.