Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: OpenShift AI #342

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Conversation

zdtsw
Copy link
Contributor

@zdtsw zdtsw commented Nov 24, 2024

  • add new channel for 2.13 and 2.16 on stable and EUS
  • add new components: trustyai and modelregistry
  • remove wait on CRD which is not from servicemesh
  • update default cert type in kserve since 2.13 changed as patch
  • update DSC CR name "default-dsc"
  • update README and INFO
  • add defaultdeployment serverless in serving patch

- add new channel for 2.13 and 2.16 on stable and EUS
- add new components: trustyai and modelregistry
- remove wait on CRD which is not from servicemesh
- update default cert type in kserve since 2.13 changed as patch
- update DSC CR name "default-dsc"
- update README and INFO
- add defaultdeployment serverless in serving patch

Signed-off-by: Wen Zhou <[email protected]>
Copy link
Contributor

@strangiato strangiato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @zdtsw, thank you for your contribution! It is always great to see engineering contributing here!

It looks like the linting actions flagged some issues that will need to be resolved. Some of the actions have added annotations directly to the issues. Some like the kustomize check you will need to view the flagged issues in the action.

I also threw a few comments on a few items as well.

The spelling issues tend to cause the most confusion. If the word is spelled correctly and is still having issues it can be added to the wordlist file to bypass the check.

Let me know if you have any issues and I would be happy to help!

- lint in yaml
- wrong file name
- update component name in newly added README
- revert DSC CR name back to "default" to not break existing users
- update .wordlist-md

Signed-off-by: Wen Zhou <[email protected]>
Copy link
Contributor

@strangiato strangiato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Thank you for the great updates!

@strangiato strangiato merged commit 9abd97d into redhat-cop:main Dec 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants