Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ImagePullSecret for pulling from private registry #584

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
070be81
support for imagepullsecret
gniltaws Nov 19, 2024
f137ade
extra space from bad paste
gniltaws Nov 21, 2024
855ce27
adjusted version
gniltaws Nov 23, 2024
99e997f
create pullsecret in testing workflow
gniltaws Nov 23, 2024
b139137
add pullsecret name to values file
gniltaws Nov 23, 2024
a7789db
imagePullSecrets was in the wrong location
gniltaws Nov 23, 2024
c7ccebc
bumped version
garethahealy Nov 25, 2024
699c7d5
Merge branch 'main' into imagePullSecret
garethahealy Nov 25, 2024
ba0d782
variable no longer at end of secret creation. Hopefully, this will f…
gniltaws Nov 25, 2024
aa05e68
removed trailing spaces
gniltaws Nov 25, 2024
5683b7e
operators-installer 3.1.0
gniltaws Dec 12, 2024
13020cb
helm chart for private registry secured by htpasswd
gniltaws Dec 12, 2024
e7b9281
WIP on making & using local private registry
gniltaws Dec 12, 2024
9b8b2d1
privateRegistry chart adds Ingress for registry
gniltaws Dec 13, 2024
6010cf5
integration test uses Ingress for push/pulling to private registry
gniltaws Dec 13, 2024
5d4e609
support for imagepullsecret
gniltaws Nov 19, 2024
d5aa33e
privateRegistry is now private-registry
gniltaws Dec 13, 2024
06ba03b
update private-registry chart name in workflow
gniltaws Dec 13, 2024
1b14cbd
add port to skopeo copy
gniltaws Dec 16, 2024
d238e62
fixed spacing
gniltaws Dec 16, 2024
3234c10
stop skopeo using port 443 for private registry
gniltaws Dec 16, 2024
6aac15c
use http for skopeo copy
gniltaws Dec 17, 2024
dc1b8d3
expose port 5000
gniltaws Dec 18, 2024
1921e71
skopeo copy back to docker:// protocol
gniltaws Dec 18, 2024
fb00230
exposing port 80 in kind cluster
gniltaws Dec 18, 2024
e37c76d
adds missing newlines at end of file
gniltaws Dec 18, 2024
fb6427a
removed extra imagePullSecrets
gniltaws Dec 19, 2024
975e97c
added 'name:' key to imagePullSecrets
gniltaws Dec 20, 2024
d3fa48d
increased timeout on the argo upgrade job
gniltaws Dec 20, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,14 @@ jobs:
--values charts/operators-installer/_integration-tests/test-install-operator-0-automatic-intermediate-manual-upgrades-values.yaml \
--debug --timeout 10m0s

echo "##########################################################################################################"
echo "# Create pull secret used in next step #"
echo "##########################################################################################################"
oc create secret docker-registry registry-redhat-io-pullsecret -n operators-installer-integration-test \
--docker-server=registry.redhat.io \
--docker-username="6340056|redhat-cop-helm-charts" \
--docker-password="${{ secrets.REDHAT_REGISTRY_TOKEN }}"

echo "##########################################################################################################"
echo "# Upgrade argo to newer version requiring many intermediate updates along the way #"
echo "##########################################################################################################"
Expand Down
2 changes: 1 addition & 1 deletion charts/operators-installer/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 3.1.0
version: 3.0.2
garethahealy marked this conversation as resolved.
Show resolved Hide resolved

home: https://github.com/redhat-cop/helm-charts

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
approveManualInstallPlanViaHook: true

installPlanApproverAndVerifyJobsImage: quay.io/openshift/origin-cli:4.15
# default image pulls from private registry registry.redhat.io
installPlanApproverAndVerifyJobsImagePullSecret: registry-redhat-io-pullsecret

operatorGroups:
- name: argocd-operator
Expand Down