Revert - wait for all snapshots to drain before returning #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a check that the all snapshots were drained Add test Add changelog fragement Signed-off-by: Ygal Blum <[email protected]>
ygalblum
force-pushed
the
revert-wait-for-drain
branch
from
ac9257d to
e632f2a
Compare
swapdisk
requested changes
Sep 28, 2023
Add group name to the select filter to make sure the returned list has only one result Co-authored-by: Bob Mader <[email protected]>
I've added your fix (thanks for that). |
swapdisk
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check that the all snapshots were drained
Add test
Add changelog fragement