Split lvm_snapshots role into separate roles #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygalblum
force-pushed
the
split-lvm_snapshot
branch
from
97f8c25 to
5559960
Compare
swapdisk
requested changes
Dec 14, 2023
ygalblum
force-pushed
the
split-lvm_snapshot
branch
from
5559960 to
acecab4
Compare
Done |
Split into three roles - create, revert and remove For create allow running only check Do not use check_for_resize as the functionality was moved to shrink_lv Signed-off-by: Ygal Blum <[email protected]>
ygalblum
force-pushed
the
split-lvm_snapshot
branch
from
acecab4 to
b6e4f90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split into three roles - create, revert and remove
For create allow running only check
Do not use check_for_resize as the functionality was moved to shrink_lv