Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bigboot repeatedly increasing the partition size #81

Merged
merged 4 commits into from
Dec 5, 2024

Conversation

swapdisk
Copy link
Member

@swapdisk swapdisk commented Dec 3, 2024

Fixes #80.

@swapdisk
Copy link
Member Author

swapdisk commented Dec 4, 2024

Got a good suggestion from @gordner... 🤔

We should make it so that the cron entry removal tasks are always run so that rerunning a play will clean up resulting in a more constant expected state. As it is now, they would not get cleaned up when rerunning after a previous incomplete run or cancelled job.

Converting PR to draft.

@swapdisk swapdisk marked this pull request as draft December 4, 2024 15:26
@swapdisk
Copy link
Member Author

swapdisk commented Dec 4, 2024

@gordner, I figured out a way to make the reboot cron entries clean up themselves. Please review...

@swapdisk swapdisk marked this pull request as ready for review December 4, 2024 23:08
@swapdisk swapdisk requested a review from ygalblum December 4, 2024 23:08
Copy link
Collaborator

@ygalblum ygalblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swapdisk swapdisk merged commit c7381c9 into redhat-cop:main Dec 5, 2024
15 checks passed
@swapdisk swapdisk deleted the fix_80 branch December 5, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bigboot repeatedly increasing the /boot partition size
2 participants