Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: start_compose changed report valid changed depending on whether or not compose was started #310

Merged
merged 5 commits into from
Oct 18, 2023
Merged

Fix: start_compose changed report valid changed depending on whether or not compose was started #310

merged 5 commits into from
Oct 18, 2023

Conversation

jharmison-redhat
Copy link
Contributor

Description

Return change status in response of start_compose module to enable idempotency

FIXES: #309

Type of change

What is it?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Tests update
  • Refactor

Checklist

  • Added changelog fragment
  • Tests exist for affected features covering positive and negative scenarios

@mergify mergify bot added bug Something isn't working test update new tests or updating existing ones labels Oct 18, 2023
@jharmison-redhat jharmison-redhat changed the title Fix/start compose changed [WIP] Fix/start compose changed Oct 18, 2023
@jharmison-redhat jharmison-redhat force-pushed the fix/start-compose-changed branch 5 times, most recently from cfb4017 to e784da5 Compare October 18, 2023 14:30
@jharmison-redhat jharmison-redhat force-pushed the fix/start-compose-changed branch from e784da5 to 0430456 Compare October 18, 2023 14:34
@jharmison-redhat jharmison-redhat changed the title [WIP] Fix/start compose changed Fix: start_compose changed report valid changed depending on whether or note compose was started Oct 18, 2023
@jharmison-redhat
Copy link
Contributor Author

jharmison-redhat commented Oct 18, 2023 •
edited
Loading

Should be good to go for review at this point, apologies for any notification spam as I force-pushed while on calls with customers so trying to make small changes quick and just look at CI output :)

@jharmison-redhat jharmison-redhat changed the title Fix: start_compose changed report valid changed depending on whether or note compose was started Fix: start_compose changed report valid changed depending on whether or not compose was started Oct 18, 2023
matoval
matoval approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@matoval matoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 7fe8e3a into redhat-cop:main Oct 18, 2023
72 checks passed
@mergify mergify bot added the waiting for review Pull request is ready for review label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matoval matoval matoval approved these changes

@maxamillion maxamillion Awaiting requested review from maxamillion maxamillion is a code owner

@thom-at-redhat thom-at-redhat Awaiting requested review from thom-at-redhat thom-at-redhat is a code owner

@de1987 de1987 Awaiting requested review from de1987 de1987 is a code owner

@resoluteCoder resoluteCoder Awaiting requested review from resoluteCoder resoluteCoder is a code owner

Assignees
No one assigned
Labels
bug Something isn't working test update new tests or updating existing ones waiting for review Pull request is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

start_compose doesn't signal changes when changes are made
2 participants
@jharmison-redhat @matoval