Add [[container]] section in generated blueprint to support embedded container images #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisarizmendi
requested review from
maxamillion,
thom-at-redhat,
de1987,
resoluteCoder and
matoval
as code owners
mergify
bot
added
enhancement
|
This Pull Request is now in conflict. Could you fix it @luisarizmendi? 🙏 |
|
This Pull Request looks stale. Feel free to reopen it if you think it's a mistake. |
|
was this merged? |
|
I'm not sure if it was even reviewed. I think I pushed twice this PR @maxamillion, @thom-at-redhat, @de1987, @resoluteCoder, @matoval if you think this cannot be merged it would be great if you point why so we can fix it. Thanks. |
|
Re-Opening this PR for further review. |
claudiol
approved these changes
Jul 25, 2024
|
This Pull Request needs all checks to run successfully. Could you fix it @luisarizmendi? 🙏 |
|
This Pull Request needs all checks to run successfully. Could you fix it @luisarizmendi? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add [[container]] section in generated blueprint to support embedded container images
Related to RFE #331
Type of change
What is it?
Checklist