Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extra-docs-linting.yml #402

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

claudiol
Copy link
Collaborator

Adding fedora collection

Description

  • Fixes issue with CI failing
    RuntimeError: The command
    | ansible-doc -vvv --metadata-dump --no-fail-on-errors amazon.aws ansible.builtin ansible.posix fedora.linux_system_roles infra.osbuild
    returned exit status 1 with error output:
    | ERROR! Cannot use supplied collection fedora.linux_system_roles: unable to locate collection fedora.linux_system_roles. unable to locate collection fedora.linux_system_roles

FIXES: CI Workflow

Type of change

What is it?

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Tests update
  • Refactor

Checklist

  • Added changelog fragment
  • Tests exist for affected features covering positive and negative scenarios

Adding fedora collection
@claudiol claudiol added the approved pm aprroved to work label Jul 25, 2024
@claudiol claudiol requested review from ericzolf and itewk and removed request for maxamillion, thom-at-redhat, de1987, resoluteCoder and matoval July 25, 2024 23:22
Copy link

@itewk itewk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. but i dont have merge permissions.

@mergify mergify bot added the waiting for review Pull request is ready for review label Jul 26, 2024
Copy link
Collaborator

@ericzolf ericzolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

mergify bot commented Jul 29, 2024

This Pull Request needs all checks to run successfully. Could you fix it @claudiol? 🙏

@mergify mergify bot added the invalid This doesn't seem right (PR check failure?) label Jul 29, 2024
@ericzolf ericzolf merged commit a849288 into redhat-cop:main Jul 29, 2024
32 of 70 checks passed
@ericzolf
Copy link
Collaborator

I'm assuming that all failed pipelines were failing before this merge so not caring. We should nevertheless look into getting the multiple pipelines back to green before we do too many more changes.

Copy link
Contributor

mergify bot commented Jul 30, 2024

This Pull Request needs all checks to run successfully. Could you fix it @claudiol? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved pm aprroved to work invalid This doesn't seem right (PR check failure?) waiting for review Pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants