Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General code improvements #41

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

dobozysaurus
Copy link

@dobozysaurus dobozysaurus commented Aug 18, 2019

General improvements for the Config, GoogleDrive2 classes:

  • Compatibility for folks running OS X (code referred to several Linux only constructs - /home/* vs /Users/*, drive_linux vs drive_darwin, etc)
  • Moved hard-coded URLs for drive_* to configs for easier updating
  • Addition of dotenv (https://github.com/cdimascio/java-dotenv) for easier maintenance of environment variables
  • Allowed credentials to be read from a file, rather than inserted directly into the environment variables
  • Preferred usage of NIO file ops (Files.createDirectories() instead of File.mkdir(), etc) because of the former's preference for failing fast vs boolean returned values that are often unchecked
  • Increased usage of Validate.* for better pre-requisite checks
  • Import cleanup
  • Cleanup of unnecessary diamond types

@dobozysaurus dobozysaurus changed the title General improvements for Config, GoogleDrive2 classes General improvements for Config, GoogleDrive2, Database2 classes Aug 20, 2019
@dobozysaurus
Copy link
Author

Also added: more encapsulation for the Database2 class; made Event and Task first class objects, added unit testing for Database2.

@dobozysaurus
Copy link
Author

@matallen @sabre1041 Wasn't sure if you all were looking for contribs on this repo, but figured I'd add some Mac friendly dev functionality and unit testing.

@matallen
Copy link
Collaborator

@dobozysaurus Yes, contributions are always welcome, especially broadening the platform in which it runs & can be developed. Please give me some time to look through the changes and I'll get back to you.

@dobozysaurus
Copy link
Author

Rebased against master to fix conflicts; added some minor cleanup for ChartsController as well.

@dobozysaurus dobozysaurus changed the title General improvements for Config, GoogleDrive2, Database2 classes General code improvements Sep 10, 2019
@dobozysaurus
Copy link
Author

@matallen Given your comments on earlier commits, and its current conflicted state, my thought on this one is to close it and divide it into a series of more focused PRs sans formatting changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants