Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made dashboard widget full width, cleaned up styling. #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dobozysaurus
Copy link

Couple minor fixes to the mojo dashboard widget:

  • Made the widget full width of the container, instead of capped at 1000.
  • Favored divs over tables
  • Nixed the border-radius:12 on the .card2.

@matallen
Copy link
Collaborator

I've reviewed the change, and thanks for making it small and contained, however there's a few issues:

  1. when the card expands it behaves as expected, however when you shrink the browser screen, then div doesnt shrink (I'm on RHEL 7 with Chrome 77.0.3865.75 ), and
  2. It's highlighted that the code in this repo for the mojo card is fairly out of date. It appears the real code is in a branch that's not been merged. I will merge the actual code back into master and we can go from there, either re-apply the change or I can
  3. also, please try not to auto-format the code, it makes it super hard to tell what's actually changed

@dobozysaurus
Copy link
Author

Thanks for looking at this, Mat! Apologies for the formatting - if there's a formatter on the project that you'd prefer I use, please let me know and I'll be glad to do so. Once you merge the code, I'll take a look at issue 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants