Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move UI out of experimental mode #7012

Merged
merged 13 commits into from
Aug 4, 2023
Merged

Move UI out of experimental mode #7012

merged 13 commits into from
Aug 4, 2023

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Aug 1, 2023 •
edited
Loading

What type of PR is this:

/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6963

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

Preview: https://odo-dev-pr-7012.odo-test-kubernete-449701-49529fc6e6a4a9fe7ebba9a3db5b55c4-0000.eu-de.containers.appdomain.cloud/docs/user-guides/advanced/using-gui/

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation labels Aug 1, 2023
@netlify
Copy link

netlify bot commented Aug 1, 2023 •
edited by github-actions bot
Loading

🔨 Deploy Preview deleted from internal cluster!

Name Link
🔨 Latest commit 5aaa30e
😎 Deploy Preview https://odo-dev-pr-7012.odo-test-kubernete-449701-49529fc6e6a4a9fe7ebba9a3db5b55c4-0000.eu-de.containers.appdomain.cloud/

@openshift-ci openshift-ci bot requested review from kadel and rm3l August 1, 2023 14:37
@odo-robot
Copy link

odo-robot bot commented Aug 1, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit 45928ca finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 1, 2023 •
edited
Loading

NoCluster Tests on commit 45928ca finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 1, 2023 •
edited
Loading

Unit Tests on commit 45928ca finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 1, 2023 •
edited
Loading

Validate Tests on commit 45928ca finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 1, 2023 •
edited
Loading

Windows Tests (OCP) on commit 45928ca finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 1, 2023 •
edited
Loading

Kubernetes Tests on commit 45928ca finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 1, 2023 •
edited
Loading

OpenShift Tests on commit 45928ca finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the feature-6963/ui-out-of-experimental branch 3 times, most recently from c680a46 to 1cf3933 Compare August 2, 2023 11:08
@feloy feloy removed the request for review from kadel August 2, 2023 11:21
@odo-robot
Copy link

odo-robot bot commented Aug 2, 2023 •
edited
Loading

Kubernetes Docs Tests on commit 7c976f1 finished successfully.
View logs: TXT HTML

@feloy feloy temporarily deployed to internal August 2, 2023 12:48 — with GitHub Actions Inactive
@feloy feloy temporarily deployed to internal August 2, 2023 13:37 — with GitHub Actions Inactive
@feloy feloy temporarily deployed to internal August 2, 2023 13:55 — with GitHub Actions Inactive
@feloy feloy changed the title [wip] Move UI out of experimental mode Move UI out of experimental mode Aug 2, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Aug 2, 2023
@feloy feloy force-pushed the feature-6963/ui-out-of-experimental branch from b7b4039 to 9f853b0 Compare August 2, 2023 14:29
@feloy feloy temporarily deployed to internal August 2, 2023 14:30 — with GitHub Actions Inactive
rm3l
rm3l requested changes Aug 3, 2023
View reviewed changes
docs/website/docs/user-guides/advanced/using-gui.md Outdated Show resolved Hide resolved
docs/website/docs/user-guides/advanced/using-gui.md Show resolved Hide resolved
docs/website/docs/user-guides/advanced/using-gui.md Outdated Show resolved Hide resolved
docs/website/docs/user-guides/advanced/using-gui.md Outdated Show resolved Hide resolved
pkg/apiserver-impl/starterserver.go Outdated Show resolved Hide resolved
ui/src/app/app.component.html Show resolved Hide resolved
@feloy feloy temporarily deployed to internal August 3, 2023 11:20 — with GitHub Actions Inactive
@feloy feloy temporarily deployed to internal August 3, 2023 11:27 — with GitHub Actions Inactive
@feloy feloy force-pushed the feature-6963/ui-out-of-experimental branch from 518e8e2 to a2bd201 Compare August 3, 2023 14:33
@feloy feloy temporarily deployed to internal August 3, 2023 14:33 — with GitHub Actions Inactive
@feloy feloy temporarily deployed to internal August 4, 2023 09:46 — with GitHub Actions Inactive
@feloy feloy requested a review from rm3l August 4, 2023 09:46
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

rm3l
rm3l approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 4, 2023
@feloy
Copy link
Contributor Author

feloy commented Aug 4, 2023

/override windows-integration-test/Windows-test

[FAILED] [3.000 seconds]
odo create/delete/list/set namespace/project tests delete namespace when force-deleting a valid namespace [BeforeEach] should successfully delete the namespace asynchronously
  [BeforeEach] C:/Users/Administrator.ANSIBLE-TEST-VS/4469/tests/integration/cmd_namespace_test.go:74
  [It] C:/Users/Administrator.ANSIBLE-TEST-VS/4469/tests/integration/cmd_namespace_test.go:96

@openshift-ci
Copy link

openshift-ci bot commented Aug 4, 2023

@feloy: Overrode contexts on behalf of feloy: windows-integration-test/Windows-test

In response to this:

/override windows-integration-test/Windows-test

[FAILED] [3.000 seconds]
odo create/delete/list/set namespace/project tests delete namespace when force-deleting a valid namespace [BeforeEach] should successfully delete the namespace asynchronously
 [BeforeEach] C:/Users/Administrator.ANSIBLE-TEST-VS/4469/tests/integration/cmd_namespace_test.go:74
 [It] C:/Users/Administrator.ANSIBLE-TEST-VS/4469/tests/integration/cmd_namespace_test.go:96

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit b93a75c into redhat-developer:main Aug 4, 2023
@openshift-merge-robot openshift-merge-robot temporarily deployed to internal August 4, 2023 11:02 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

Assignees

@rm3l rm3l

Labels
kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move odo dev UI out of the experimental mode
3 participants
@feloy @rm3l @openshift-merge-robot