Addressing comments from b. Crochet

redhat-openshift-ecosystem · Jan 24, 2024 · 950b000 · 950b000
1 parent bb672db
commit 950b000
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/certification/results.go b/certification/results.go
@@ -15,7 +15,7 @@ type Result struct {
 	// Err contains the error a check itself throws if it failed to run.
 	// If populated, the expectation is that this Result is in the
 	// Results{}.Errors slice.
-	Err error
+	err error
 }
 
 type Results struct {
@@ -28,3 +28,12 @@ type Results struct {
 	Errors            []Result
 	Warned            []Result
 }
+
+func (r Result) Error() error {
+	return r.err
+}
+
+func (r *Result) WithError(err error) *Result {
+	r.err = err
+	return r
+}
diff --git a/internal/engine/engine.go b/internal/engine/engine.go
@@ -231,7 +231,8 @@ func (c *craneEngine) ExecuteChecks(ctx context.Context) error {
 
 		if err != nil {
 			logger.WithValues("result", "ERROR", "err", err.Error()).Info("check completed", "check", executedCheck.Name())
-			c.results.Errors = appendUnlessOptional(c.results.Errors, certification.Result{Check: executedCheck, ElapsedTime: checkElapsedTime, Err: err})
+			result := certification.Result{Check: executedCheck, ElapsedTime: checkElapsedTime}
+			c.results.Errors = appendUnlessOptional(c.results.Errors, *result.WithError(err))
 			continue
 		}