Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update doc url #1074

Merged
merged 4 commits into from
Oct 16, 2023
Merged

Update doc url #1074

merged 4 commits into from
Oct 16, 2023

Conversation

aksaswadkar
Copy link
Contributor

Added the correct document URL in the certified_image.go for the certifiedImages check.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 9, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 9, 2023

Hi @aksaswadkar. Thanks for your PR.

I'm waiting for a redhat-openshift-ecosystem member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcibot
Copy link

dcibot commented Oct 9, 2023

@acornett21
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 9, 2023
@acornett21
Copy link
Contributor

HI @aksaswadkar It looks like you raised two pr's with overlapping info I assume you will close the other pr? Can you also search for red_hat_software_certification in the entire project and update all links to 8.68? Thanks!

@aksaswadkar
Copy link
Contributor Author

Hi @acornett21 I closed the other PR and sure, I will find and update the URL to the latest version.

@aksaswadkar aksaswadkar changed the title Update doc url certified images Update doc url Oct 10, 2023
@dcibot
Copy link

dcibot commented Oct 10, 2023

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 10, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2023
@aksaswadkar
Copy link
Contributor Author

Hi @acornett21 Updated the URLs to 8.69, please review.

@dcibot
Copy link

dcibot commented Oct 16, 2023

bcrochet
bcrochet reviewed Oct 16, 2023
View reviewed changes
Copy link
Contributor

@bcrochet bcrochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a question, but otherwise lgtm.

README.md
@@ -16,7 +16,7 @@ subject to change, and some features are not fully implemented.
## Certification Workflow Guide

For the complete container and operator bundle certification workflow instructions, please reference our
[official certification documentation](https://access.redhat.com/documentation/en-us/red_hat_software_certification/8.56/html/red_hat_software_certification_workflow_guide/index).
[official certification documentation](https://access.redhat.com/documentation/en-us/red_hat_software_certification/8.69/html/red_hat_software_certification_workflow_guide/index).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won't keep this from going in, but is there instead a 'latest' URL that we can use in preflight, so that it does not require a code change and a release in order for these to be updated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bcrochet there is no 'latest' URL, each URL has got the new version(8.6x). It'd be great to not have the version in the URL then we won't have to update it when there is a new version which is every 3-4 weeks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to figure out a redirector then that is external to preflight.

bcrochet
bcrochet approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@bcrochet bcrochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, aksaswadkar, bcrochet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [acornett21,bcrochet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bcrochet bcrochet merged commit 1fb41c2 into redhat-openshift-ecosystem:main Oct 16, 2023
1 check passed
@aksaswadkar aksaswadkar deleted the update_doc_URL_certified_images branch October 17, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcrochet bcrochet bcrochet approved these changes

@tonytcampbell tonytcampbell Awaiting requested review from tonytcampbell

@acornett21 acornett21 Awaiting requested review from acornett21

Assignees

@bcrochet bcrochet

@acornett21 acornett21

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aksaswadkar @dcibot @acornett21 @bcrochet @asaswadk