Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating go to 1.21 #1082

Merged
merged 1 commit into from
Oct 31, 2023
Merged

updating go to 1.21 #1082

merged 1 commit into from
Oct 31, 2023

Conversation

acornett21
Copy link
Contributor

@acornett21 acornett21 commented Oct 11, 2023 •
edited
Loading

  • updating to go 1.21
  • updating to latest 15 series of controller runtime
  • updating to latest 27 series of k8's libraries

This will resolve rapid-rest CVE issue(s).

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2023
@dcibot
Copy link

dcibot commented Oct 11, 2023

@dcibot
Copy link

dcibot commented Oct 11, 2023

komish
komish approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2023
@acornett21 acornett21 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2023
@acornett21
Copy link
Contributor Author

Put this PR on hold, since I don't think there is a go 1.21 image for our CI yet.

@acornett21
updating go to 1.21
119e76c 
Signed-off-by: Adam D. Cornett <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2023
@acornett21 acornett21 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2023
@acornett21
Copy link
Contributor Author

Removing hold on this PR since fixing the CVE's are more important then waiting on prow to have an updated golang image.

@dcibot
Copy link

dcibot commented Oct 31, 2023

bcrochet
bcrochet approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@bcrochet bcrochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, bcrochet, komish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [acornett21,bcrochet,komish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bcrochet bcrochet merged commit f1bfa27 into redhat-openshift-ecosystem:main Oct 31, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komish komish komish approved these changes

@bcrochet bcrochet bcrochet approved these changes

@skattoju skattoju Awaiting requested review from skattoju

Assignees

@bcrochet bcrochet

@komish komish

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acornett21 @dcibot @bcrochet @komish