updating operator framework api dependency #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
komish
reviewed
Jan 22, 2024
internal/bundle/bundle.go
Outdated
Comment on lines
47
to
48
| // OperatorHubV2Validator, StandardCapabilitiesValidator and StandardCategoriesValidator provide the same functionality | ||
| // as the deprecated OperatorHubValidator validator |
There was a problem hiding this comment.
Nit: We probably don't need these comments here. It was useful for my review, but I don't think it needs to live in the source.
There was a problem hiding this comment.
Agreed. Should just live in the commit message.
komish
approved these changes
Jan 22, 2024
bcrochet
reviewed
Jan 22, 2024
internal/bundle/bundle.go
Outdated
Comment on lines
47
to
48
| // OperatorHubV2Validator, StandardCapabilitiesValidator and StandardCategoriesValidator provide the same functionality | ||
| // as the deprecated OperatorHubValidator validator |
There was a problem hiding this comment.
Agreed. Should just live in the commit message.
…ues caused by the update OperatorHubV2Validator, StandardCapabilitiesValidator and StandardCategoriesValidator provide the same functionality as the deprecated OperatorHubValidator validator Signed-off-by: Adam D. Cornett <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acornett21, bcrochet, komish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
from change #1116: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
operator-framework/apiand migrating to new validations, since the original is depricatedNote: OperatorHubV2Validator, StandardCapabilitiesValidator and StandardCategoriesValidator provide the same functionality as the deprecated OperatorHubValidator validator