Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ocp 4.16 / k8s 1.29 to ocp to k8s conversion map #1130

Merged
merged 1 commit into from
Mar 4, 2024
Merged

add ocp 4.16 / k8s 1.29 to ocp to k8s conversion map #1130

merged 1 commit into from
Mar 4, 2024

Conversation

acornett21
Copy link
Contributor

  • Adding the next version of OCP to the conversion map in the bundle code.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2024
@dcibot
Copy link

dcibot commented Feb 28, 2024

from change #1130:

@acornett21
Copy link
Contributor Author

from change #1130:

This isn't due to any code change, but due to the fact that opm is only built on/for RHEL9 so there is a mismatch in glibc versions.

komish
komish approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, komish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tonyskapunk
Copy link

check workload preflight-green

@dcibot
Copy link

dcibot commented Feb 29, 2024

from change #1130:

@tonyskapunk
Copy link

check workload preflight-green

@acornett21
Copy link
Contributor Author

/retest all

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 1, 2024

@acornett21: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test 4.12-e2e
  • /test 4.12-images
  • /test 4.14-e2e
  • /test 4.14-images

Use /test all to run all jobs.

In response to this:

/retest all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@acornett21 acornett21 closed this Mar 1, 2024
@acornett21 acornett21 reopened this Mar 1, 2024
@dcibot
Copy link

dcibot commented Mar 1, 2024

from change #1130:

@acornett21
Copy link
Contributor Author

/retest-required

@acornett21 acornett21 merged commit 7812660 into redhat-openshift-ecosystem:main Mar 4, 2024
8 checks passed
@acornett21 acornett21 deleted the add_ocp_4_16 branch March 4, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komish komish komish approved these changes

@bcrochet bcrochet Awaiting requested review from bcrochet

Assignees

@komish komish

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acornett21 @dcibot @tonyskapunk @komish