fix: propagates test script error code correctly #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
General question about this script - do you plan to adjust it after the repo split? |
bartoszmajsak
referenced
this pull request
in maistra/istio-workspace
Sep 22, 2021
The reason is that operator testing harness we rely expects the structure of the repo prior to the split and will not work yet with the new approach. I have raised the question in the repo on one of my PRs https://github.com/redhat-openshift-ecosystem/operator-test-playbooks/pull/247\#issuecomment-923966892
|
Hello? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if test script fails at some point it will log error but exit with
0. This is because it will take$?return code from echo which prints the original error code.This PR keeps actual error code in the variable to avoid this issue.