Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sudo by glance-api #109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions os-glance.te
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ optional_policy(`
gen_tunable(os_glance_use_sudo, false)
tunable_policy(`os_glance_use_sudo',`
sudo_exec(glance_api_t)
auth_use_pam(glance_api_t)
init_rw_utmp(glance_api_t)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Nit, minor) It may be good to reference the bugzilla in a comment near these.

logging_send_audit_msgs(glance_api_t)
iscsid_domtrans(glance_api_t)
fstools_domtrans(glance_api_t)
Expand Down
2 changes: 2 additions & 0 deletions tests/bz2255412
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
type=AVC msg=audit(1703084811.884:6481): avc: denied { execute } for pid=72459 comm="sudo" name="unix_chkpwd" dev="vda1" ino=4700890 scontext=system_u:system_r:glance_api_t:s0 tcontext=system_u:object_r:chkpwd_exec_t:s0 tclass=file permissive=0
type=AVC msg=audit(1703084818.067:6524): avc: denied { execute } for pid=72505 comm="sudo" name="unix_chkpwd" dev="vda1" ino=4700890 scontext=system_u:system_r:glance_api_t:s0 tcontext=system_u:object_r:chkpwd_exec_t:s0 tclass=file permissive=0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(question, non-blocking) Is this is the only denial or are there more when running in permissive mode?