Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VM verification and Logs #896

Merged
merged 1 commit into from
Sep 24, 2024
Merged

VM verification and Logs #896

merged 1 commit into from
Sep 24, 2024

Conversation

ebattat
Copy link
Collaborator

@ebattat ebattat commented Sep 19, 2024 •
edited
Loading

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

  1. Add VM verification during the OpenShift upgrade process.
  2. Collect logs in case of VM errors and update the error and log path in ElasticSearch
  3. Generate must-gather logs for ODF and CNV in case of errors.
  4. Upload logs to Google Drive using a timestamped hierarchy like '2024/09/19'.
  5. The second option for log storage is S3, default being local storage.

Related to issue #862

For security reasons, all pull requests need to be approved first before running any automated CI

@ebattat ebattat added the enhancement New feature or request label Sep 19, 2024
@ebattat ebattat self-assigned this Sep 19, 2024
@ebattat ebattat added the ok-to-test PR ok to test label Sep 19, 2024
@ebattat ebattat force-pushed the vm_verification_log branch 3 times, most recently from f2f4c2c to 0f609c5 Compare September 22, 2024 08:14
RobertKrawitz
RobertKrawitz requested changes Sep 23, 2024
View reviewed changes
Copy link
Member

@RobertKrawitz RobertKrawitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things.

benchmark_runner/common/oc/oc.py Outdated Show resolved Hide resolved
benchmark_runner/common/google_drive/google_drive_operations.py Outdated Show resolved Hide resolved
@ebattat ebattat merged commit 6f5d956 into redhat-performance:main Sep 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertKrawitz RobertKrawitz RobertKrawitz approved these changes

Assignees

@ebattat ebattat

Labels
enhancement New feature or request ok-to-test PR ok to test
Projects
benchmark-runner
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ebattat @RobertKrawitz