Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced the closed ticket cost #657

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

athiruma
Copy link
Collaborator

@athiruma athiruma commented Aug 3, 2023

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

Missed the reduction of closed ticket costs in the last 30 days. If the user opens the ticket and the ticket will close in 10 days we miss the cost. So adding the get closed tickets cost, will get the cost and reduced it from the total ticket cost.

For security reasons, all pull requests need to be approved first before running any automated CI

@athiruma athiruma added bug Something isn't working dependencies Pull requests that update a dependency file labels Aug 3, 2023
@athiruma athiruma requested a review from ebattat August 3, 2023 08:55
@athiruma athiruma self-assigned this Aug 3, 2023
Copy link
Collaborator

@ebattat ebattat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@athiruma, why we should reduced close ticket from the budget ?
I think if some open ticket on X$ and didnt use it, it should gone

@athiruma
Copy link
Collaborator Author

athiruma commented Aug 3, 2023

@athiruma, why we should reduced close ticket from the budget ?

Here the scenario last 30 days ( 3-July to 3-aug)
The user Opened the ticket on 10 July and completed the budget on 15 July.
Requested Budget: $ 1000
CurrentDay User Budget: $ 1500
So, if remove 1000 from the budget, there left 500.

I think if some open ticket on X$ and didnt use it, it should gone

To tackle this situation I added the user's daily cost to es. I reduced only that cost.

@athiruma athiruma added the ok-to-test PR ok to test label Aug 3, 2023
Copy link
Collaborator

@ebattat ebattat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ebattat ebattat merged commit 27ea7a9 into redhat-performance:main Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file ok-to-test PR ok to test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants