Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the zombie_cluster global resources #838

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Fixed the zombie_cluster global resources #838

merged 1 commit into from
Sep 19, 2024

Conversation

athiruma
Copy link
Collaborator

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

  1. Skip the deletion of IAM User, as it is risky permission.
  2. If the zombie_cluster has only IAM Role/ S3 bucket, upload to elastic search only if ran in region=us-east-1

For security reasons, all pull requests need to be approved first before running any automated CI

@athiruma athiruma added bug Something isn't working ok-to-test PR ok to test labels Sep 17, 2024
@athiruma athiruma self-assigned this Sep 17, 2024
ebattat
ebattat reviewed Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@ebattat ebattat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@athiruma, did u test it locally ?

@athiruma
Copy link
Collaborator Author

@athiruma, did u test it locally ?

yes, I did.

@athiruma athiruma force-pushed the fix_zombe_clustr_globl_resources branch from 5c559a8 to cbea2a1 Compare September 18, 2024 07:54
ebattat
ebattat approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@ebattat ebattat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ebattat ebattat merged commit 9fad192 into redhat-performance:main Sep 19, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebattat ebattat ebattat approved these changes

Assignees

@athiruma athiruma

Labels
bug Something isn't working ok-to-test PR ok to test
Projects
Cloud-Governance project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@athiruma @ebattat