Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check tag_value 'owned' when found cluster tag #867

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

athiruma
Copy link
Collaborator

@athiruma athiruma commented Nov 8, 2024

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

check tag_value 'owned' when found cluster tag. This implies a strict cluster check.
tag looks like - kubernetes.io/cluster/test: Owned

For security reasons, all pull requests need to be approved first before running any automated CI

@athiruma athiruma added bug Something isn't working ok-to-test PR ok to test labels Nov 8, 2024
@athiruma athiruma requested a review from ebattat November 8, 2024 09:44
@athiruma athiruma self-assigned this Nov 8, 2024
Copy link
Collaborator

@ebattat ebattat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ebattat
Copy link
Collaborator

ebattat commented Nov 10, 2024

@athiruma, did you test it ?

@athiruma
Copy link
Collaborator Author

@athiruma, did you test it ?

Yes, We don't have any problem. Here I added one extra check to know the cluster.

@ebattat ebattat merged commit 8e07c13 into redhat-performance:main Nov 11, 2024
29 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ok-to-test PR ok to test
Projects
Development

Successfully merging this pull request may close these issues.

2 participants