Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the tags to classic bm/vm #874

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Added the tags to classic bm/vm #874

merged 1 commit into from
Nov 19, 2024

Conversation

athiruma
Copy link
Collaborator

Type of change

Note: Fill x in []

  • bug
  • [] enhancement
  • documentation
  • dependencies

Description

  • This PR adds the ability to tag the classic bare metals/ virtual machines directly from the tag_resources policy instead of using a different policy.
  • Fixed the trailing spaces on tags key and values.

For security reasons, all pull requests need to be approved first before running any automated CI

@athiruma athiruma added bug Something isn't working ok-to-test PR ok to test labels Nov 19, 2024
@athiruma athiruma self-assigned this Nov 19, 2024
ebattat
ebattat approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@ebattat ebattat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ebattat ebattat merged commit 1ca0068 into redhat-performance:main Nov 19, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebattat ebattat ebattat approved these changes

Assignees

@athiruma athiruma

Labels
bug Something isn't working ok-to-test PR ok to test
Projects
Cloud-Governance project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@athiruma @ebattat