Added the policy name to cost-savings #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athiruma
added
documentation
ebattat
reviewed
Nov 20, 2024
| @@ -27,7 +28,7 @@ def __init__(self): | |||
| self._ec2_operations = EC2Operations(region=self._region) | |||
| self._cloudwatch = CloudWatchOperations(region=self._region) | |||
| self._resource_pricing = ResourcesPricing() | |||
| self.cost_savings_tag = [{'Key': 'cost-savings', 'Value': 'true'}] | |||
| self.cost_savings_tag = [{'Key': 'cost-savings', 'Value': self.policy_name}] | |||
There was a problem hiding this comment.
Do you think it better to create another tag ?
policy:policy_name
There was a problem hiding this comment.
No need.
cost-savings: policy_name specifies the savings amount on that policy.
athiruma
force-pushed
the
add_cost_savings_policy_name
branch
from
182bee8
to
7a88b57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Note: Fill x in []
Description
Replace policy name in cost-savings tag.
For security reasons, all pull requests need to be approved first before running any automated CI