Bring your own lab (BYOL) doc #407

sferlin · 2023-11-10T17:46:48Z

Changes needed to jetlag to make a bm ipv4 connected install in a Dell r660/r670 BYOL with RHEL 9.2.

akrzos

Got some feedback, thanks for getting this in an working through all of those issues in a new lab!!

ansible/inventory/inventory-bm-byol.sample

akrzos · 2023-11-13T20:14:30Z

ansible/inventory/inventory-bm-byol.sample

+bmc_user=root
+bmc_password=password
+lab_interface=<lab_mac interface name>
+network_interface=<anything, not used>


Might want to be careful saying "anything, not used" since the network_interface is the var used to determine the actual interface for the network that the ocp cluster is deployed on.

I found that this var need to be here, but the value is "not used". May be it is overwritten by all.yml.

I just wrote anything in my experiments without taking any effect. In the sample file it is written as "eth0".

ansible/roles/bastion-assisted-installer/tasks/main.yml

akrzos · 2023-11-13T20:26:30Z

docs/bastion-deploy-bm-byol.md

+
+The bastion machine needs 2 interfaces:
+- The interface connected to the network, i.e., with an IP assigned, a L3 network.
+- The control-plane interface, from which the cluster nodes are accessed (this is a L2 network, i.e., it does have an IP assigned).


I think with

it does have an IP assigned

you meant does not have an IP assigned?

akrzos · 2023-11-13T20:28:59Z

docs/bastion-deploy-bm-byol.md

+In a BYOL, due to the non-standard interface names and NIC PCI slots, we have to craft jetlag's inventory file by hand.
+
+The bastion machine needs 2 interfaces:
+- The interface connected to the network, i.e., with an IP assigned, a L3 network.


Might want to add a note here that this network is typically referenced as a lab network as it provides the connectivity into the bastion machine.

akrzos · 2023-11-13T20:45:19Z

docs/bastion-deploy-bm-byol.md

+# Lab & cluster infrastructure vars
+################################################################################
+# Which lab to be deployed into (Ex scalelab)
+lab: alias


We will want to change this to byol when we add that term to the permitted list.

akrzos · 2023-11-13T20:47:13Z

docs/bastion-deploy-bm-byol.md

+
+- The disks could vary from SATA/SAS to NVME, and therefore the /dev/disk/by-path IDs will vary. 
+
+- The task ''Clean lab interfaces'' will fail if there is no file at this location `/root/clean-interface.sh`.


We can add a when statement and skip when lab is set to byol to address this.

akrzos · 2023-11-13T20:48:22Z

docs/bastion-deploy-bm-byol.md

+
+- The task ''Clean lab interfaces'' will fail if there is no file at this location `/root/clean-interface.sh`.
+
+- `/root/bm/opm-linux.tar.gz` failed to be downloaded.


This is fixed now thanks to @radez with #404

akrzos · 2023-11-13T20:49:31Z

docs/bastion-deploy-bm-byol.md

+
+- `/root/bm/opm-linux.tar.gz` failed to be downloaded.
+
+- The task 'Stop and disable iptables' failed because dnf install iptables-services and start with systemctl needed to be done.


We might want to add some error handling on this task or make sure that iptables-services is in the list of packages to be installed or perhaps there is a better solution. I'll take a look in the near future.

akrzos · 2023-11-13T20:51:57Z

docs/bastion-deploy-bm-byol.md

+- The task 'Stop and disable iptables' failed because dnf install iptables-services and start with systemctl needed to be done.
+
+Some pods of the setup-bastion did not come up with "permission denied" issues. In our [blog](https://www.redhat.com/sysadmin/container-permission-denied-errors) SELinux seemed to be the cause when containers mount a writable volume, as starting the container manually (without mounting the volume) worked, i.e., UID 26 was also correct.
+The suggestion of appending a ":Z" flag at the end (instead of touching SELinux in general) fixed it.


Ah this makes sense, so the typical Scale and Alias lab machines come with rhel 8 and with selinux set to permissive instead of enabled. It seems the machines you have in the lab must have had selinux set to enabled. I don't particularly like the idea of saying you must disable or make selinux permissive, so we should see if the :Z flag works out of the box with scale/alias lab machines instead IMHO.

HughNhan · 2023-11-21T19:40:21Z

ansible/inventory/inventory-bm-byol.sample

+<IP or FQDN> ansible_ssh_user=root bmc_address=<IP or FQDN>
+
+[bastion:vars]
+bmc_user=root


"root" should be generalized. it is not always "root"

HughNhan · 2023-11-21T19:52:27Z

ansible/inventory/inventory-bm-byol.sample

+[controlplane:vars]
+role=master
+boot_iso=discovery.iso
+bmc_user=root


"root". Ditto

HughNhan · 2023-11-21T19:54:37Z

ansible/inventory/inventory-bm-byol.sample

+bmc_user=root
+bmc_password=password
+lab_interface=<lab_mac interface name>
+network_interface=<anything, not used>


I found that this var need to be here, but the value is "not used". May be it is overwritten by all.yml.

HughNhan · 2023-11-21T19:55:22Z

ansible/inventory/inventory-bm-byol.sample

+[worker:vars]
+role=worker
+boot_iso=discovery.iso
+bmc_user=root


"root". Ditto.

ansible/roles/bastion-assisted-installer/tasks/main.yml

HughNhan · 2023-11-21T20:18:08Z

docs/bastion-deploy-bm-byol.md

+Complete!
+```
+
+4. Setup ssh keys on the bastion and copy to itself to permit local ansible interactions


If we generate new ssh keys, we do not need step 2 above.

HughNhan · 2023-11-21T20:33:52Z

docs/bastion-deploy-bm-byol.md

+# you must stop and rm all assisted-installer containers on the bastion and rerun
+# the setup-bastion step in order to setup your bastion's assisted-installer to
+# the version you specified
+ocp_release_image: quay.io/openshift-release-dev/ocp-release:4.14.1-x86_64


Generalize the name

HughNhan · 2023-11-21T20:34:07Z

docs/bastion-deploy-bm-byol.md

+ocp_release_image: quay.io/openshift-release-dev/ocp-release:4.14.1-x86_64
+
+# This should just match the above release image version (Ex: 4.13)
+openshift_version: "4.14"


Generalize the version

HughNhan · 2023-11-21T20:38:29Z

docs/bastion-deploy-bm-byol.md

+smcipmitool_url:
+
+bastion_lab_interface: eno8303 #ens1f0
+bastion_controlplane_interface: ens1f0 #eno8303


These two interfaces are not fixed. The lab_interface is whatever the BYOL comes with. The controlplane_interface is a choice decided when we crafted the inventory file.

HughNhan · 2023-11-21T20:40:02Z

docs/bastion-deploy-bm-byol.md

+################################################################################
+# Network configuration for all bm cluster and rwn control-plane nodes
+controlplane_lab_interface: eno8303 #eno12399
+controlplane_network_interface: eno12399 #eno8303


Same here. These two interfaces are not fixed. Choose them correctly.

ansible/roles/bastion-assisted-installer/tasks/main.yml

Noreen21 · 2023-11-22T19:59:02Z

docs/bastion-deploy-bm-byol.md

+
+### Lab & cluster infrastructure vars
+
+Change `lab` to `lab: scalelab or ibmcloud or alias`


I second this suggestion

Noreen21 · 2023-11-22T20:01:21Z

docs/bastion-deploy-bm-byol.md

+
+Change `lab` to `lab: scalelab or ibmcloud or alias`
+
+Change `lab_cloud` to `lab_cloud: na`


If we use byol in rh_labs , then this should be lab_cloud: byol

docs/bastion-deploy-bm-byol.md

Noreen21 · 2023-11-22T20:08:58Z

docs/bastion-deploy-bm-byol.md

+
+- I observed that the file `/root/bm/opm-linux.tar.gz` could fail to be downloaded.
+
+- The task ''Stop and disable iptables'' failed because `dnf install iptables-services` and `systemctl start` needed to be done.


Same, maybe we can make the entire tone of this guide "instructional" as opposed to writing a more personal account of your experience? Applies to the next few statements also.

akrzos

The selinux changes are working even with selinux in permissive, however we should apply it to all volume mounts for all podman containers in jetlag.

ansible/roles/bastion-assisted-installer/tasks/main.yml

ansible/roles/bastion-install/tasks/main.yml

docs/bastion-deploy-bm-byol.md

…dits

akrzos

I think we need a few more changes before merging this.

ansible/vars/lab.yml

docs/bastion-deploy-bm-byol.md

ansible/roles/validate-vars/tasks/main.yml

docs/bastion-deploy-bm-byol.md

ansible/roles/bastion-install/tasks/main.yml

sferlin mentioned this pull request Nov 13, 2023

Document BYOL for everyone to be able to use #405

Closed

akrzos requested review from HughNhan and Noreen21 November 13, 2023 19:49

akrzos requested changes Nov 13, 2023

View reviewed changes

HughNhan reviewed Nov 21, 2023

View reviewed changes

Noreen21 requested changes Nov 22, 2023

View reviewed changes

sferlin force-pushed the doc_byol branch 2 times, most recently from ac50f12 to b22d255 Compare November 23, 2023 13:26

BYOL: First review adding some latest nits from the reviewers

76bf533

sferlin force-pushed the doc_byol branch from b22d255 to 76bf533 Compare November 23, 2023 13:34

akrzos and others added 3 commits November 23, 2023 14:39

BYOL: First review adding some latest nits from the reviewers

b7ea130

BYOL: Nits, mainly text/editorial fixes

3c9013d

BYOL: Nits, mainly text/editorial fixes

e6aca28

Noreen21 requested review from Noreen21 and HughNhan November 27, 2023 16:14

akrzos requested changes Nov 27, 2023

View reviewed changes

ansible/roles/bastion-assisted-installer/tasks/main.yml Show resolved Hide resolved

akrzos reviewed Nov 28, 2023

View reviewed changes

ansible/roles/bastion-install/tasks/main.yml Outdated Show resolved Hide resolved

akrzos reviewed Nov 28, 2023

View reviewed changes

docs/bastion-deploy-bm-byol.md Outdated Show resolved Hide resolved

sferlin added 2 commits December 8, 2023 14:09

BYOL: Edits to troubleshooting

0f983d6

BYOL - Last edits appending :Z to volume mounts and a few more text e…

7729644

…dits

akrzos requested changes Dec 14, 2023

View reviewed changes

sferlin added 2 commits December 15, 2023 11:47

BYOL - Polishing and more edits to the guide

97d597a

BYOL - Polishing, making the text more as a guide / passive voice

2b817f4

akrzos requested changes Dec 15, 2023

View reviewed changes

ansible/roles/bastion-install/tasks/main.yml Outdated Show resolved Hide resolved

sferlin added 2 commits December 19, 2023 10:37

BYOL: Fix to ansible syntax and a few other text fixes.

1c23b92

BYOL: Only final text fixes.

e85d54d

akrzos approved these changes Dec 21, 2023

View reviewed changes

akrzos merged commit ae939a6 into redhat-performance:main Dec 21, 2023

akrzos mentioned this pull request Jan 15, 2024

Enforced SELinux policy would not let containers to access the mounted host files #107

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bring your own lab (BYOL) doc #407

Bring your own lab (BYOL) doc #407

sferlin commented Nov 10, 2023

akrzos left a comment

akrzos Nov 13, 2023

HughNhan Nov 21, 2023

sferlin Nov 22, 2023

akrzos Nov 13, 2023

akrzos Nov 13, 2023

akrzos Nov 13, 2023

akrzos Nov 13, 2023

akrzos Nov 13, 2023

akrzos Nov 13, 2023

akrzos Nov 13, 2023

HughNhan Nov 21, 2023

HughNhan Nov 21, 2023

HughNhan Nov 21, 2023

HughNhan Nov 21, 2023

HughNhan Nov 21, 2023

HughNhan Nov 21, 2023

HughNhan Nov 21, 2023

HughNhan Nov 21, 2023

HughNhan Nov 21, 2023

Noreen21 Nov 22, 2023

Noreen21 Nov 22, 2023

Noreen21 Nov 22, 2023

akrzos left a comment

akrzos left a comment


		- The disks could vary from SATA/SAS to NVME, and therefore the /dev/disk/by-path IDs will vary.

		- The task ''Clean lab interfaces'' will fail if there is no file at this location `/root/clean-interface.sh`.


		- The task ''Clean lab interfaces'' will fail if there is no file at this location `/root/clean-interface.sh`.

		- `/root/bm/opm-linux.tar.gz` failed to be downloaded.


		- `/root/bm/opm-linux.tar.gz` failed to be downloaded.

		- The task 'Stop and disable iptables' failed because dnf install iptables-services and start with systemctl needed to be done.


		### Lab & cluster infrastructure vars

		Change `lab` to `lab: scalelab or ibmcloud or alias`


		Change `lab` to `lab: scalelab or ibmcloud or alias`

		Change `lab_cloud` to `lab_cloud: na`


		- I observed that the file `/root/bm/opm-linux.tar.gz` could fail to be downloaded.

		- The task ''Stop and disable iptables'' failed because `dnf install iptables-services` and `systemctl start` needed to be done.

Bring your own lab (BYOL) doc #407

Bring your own lab (BYOL) doc #407

Conversation

sferlin commented Nov 10, 2023

akrzos left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

akrzos left a comment

Choose a reason for hiding this comment

akrzos left a comment

Choose a reason for hiding this comment