Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repository owners #568

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

rsevilla87
Copy link
Member

@rsevilla87 rsevilla87 commented Nov 19, 2024

Please @akrzos, feel free to update the approvers/reviewers list accordingly, you have better control on the current project's community/contributors.

cc: @radez

@rsevilla87 rsevilla87 changed the title Add repository wners Add repository owners Nov 19, 2024
Copy link
Member

@akrzos akrzos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Raul Sevilla <[email protected]>
@akrzos
Copy link
Member

akrzos commented Nov 19, 2024

Lets see if CI will run this

/test deploy-sno

@akrzos
Copy link
Member

akrzos commented Nov 19, 2024

@josecastillolema so this job has completed is therfe more output I would see that indeed an SNO was built and is running? I only observed this in the logs:

...
�[36mINFO�[0m[2024-11-19T15:08:13Z] Running step deploy-sno-openshift-qe-installer-bm-deploy. 
�[36mINFO�[0m[2024-11-19T16:07:26Z] Step deploy-sno-openshift-qe-installer-bm-deploy succeeded after 59m12s. 
�[36mINFO�[0m[2024-11-19T16:07:26Z] Step phase test succeeded after 1h0m9s.      
�[36mINFO�[0m[2024-11-19T16:07:26Z] Running multi-stage phase post               
�[36mINFO�[0m[2024-11-19T16:07:26Z] Step phase post succeeded after 0s.          
�[36mINFO�[0m[2024-11-19T16:07:26Z] Releasing leases for test deploy-sno         
�[36mINFO�[0m[2024-11-19T16:07:26Z] Ran for 1h5m12s                              
�[36mINFO�[0m[2024-11-19T16:07:26Z] Reporting job state 'succeeded' 

I also found the actual playbook logs however I think a small health check to verify a healthy cluster is actually built would be fundamental to this CI test.

@josecastillolema
Copy link
Collaborator

Good point @akrzos ,
We can add a small health check (maybe running kube-burner health-check @rsevilla87 ?)
However we need to wait until some connectivity tickets are solved first, we will keep you posted.

@josecastillolema
Copy link
Collaborator

/lgtm

@akrzos
Copy link
Member

akrzos commented Nov 19, 2024

/approve

Copy link

openshift-ci bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akrzos, rsevilla87

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rsevilla87 rsevilla87 merged commit 31b482c into redhat-performance:main Nov 19, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants