Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 1d expiration to tmp operator-sdk images #15

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Add 1d expiration to tmp operator-sdk images #15

merged 1 commit into from
Oct 19, 2023

Conversation

tkrishtop
Copy link
Contributor

@tkrishtop tkrishtop commented Oct 18, 2023 •
edited
Loading

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/cb4c9dc504e94ac8924b82335590339c

✔️ dci-rpm-build-el8 SUCCESS in 4m 09s
✔️ dci-rpm-build-el9 SUCCESS in 3m 53s

@tkrishtop
Copy link
Contributor Author

check workload operator-sdk

@tkrishtop
Copy link
Contributor Author

check dallas ocp-4.13-vanilla operator-sdk

@tkrishtop
Copy link
Contributor Author

check workload operator-sdk

@dcibot
Copy link
Collaborator

dcibot commented Oct 19, 2023

manurodriguez
manurodriguez approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@manurodriguez manurodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do you know what is the default expiration time? I was trying to find, some docs show 14 days, but I was not sure if it depends on the version of quay or its configuration.

betoredhat
betoredhat reviewed Oct 19, 2023
View reviewed changes
roles/operator_sdk/tasks/build_scorecard_image.yml Outdated
@@ -30,6 +30,7 @@
cmd: >
podman buildx build
-t {{ operator_sdk_img }}
-l quay.expires-after=2w
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Tatiana,

I seems like Labels are not supported during the build. You may need to add the label to the docker file before building.

https://github.com/redhat-cip/dci-openshift-agent/blob/84a991f1b927a8358655c1d63066ab37bc708d69/plays/upstream-sriov-bundle.yml#L26

In the test, I do not see that the image was built.

Thanks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, I see it is there with --label

podman buildx build --help|grep label
      --identity-label                               add default identity label (default true)
      --label stringArray                            set metadata for an image (default [])

Copy link
Contributor Author

@tkrishtop tkrishtop Oct 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Beto, thanks for checking, and sorry for the confusing test, I was just exploring if webhook for this repo works :)

To have the image built, I need to use an operator-sdk PR in the dependencies, I'll add the dependencies and run this test asap.

Thanks for the warning about labels, let me try it out and if it would not work, I'll update the Dockerfile.

@tkrishtop
Copy link
Contributor Author

check workload operator-sdk

@dcibot
Copy link
Collaborator

dcibot commented Oct 19, 2023

@dcibot dcibot mentioned this pull request Oct 19, 2023
Draft
@tkrishtop
Copy link
Contributor Author

LGTM, do you know what is the default expiration time? I was trying to find, some docs show 14 days, but I was not sure if it depends on the version of quay or its configuration.

By default, the expiration date in our local quay is never.

@tkrishtop
Copy link
Contributor Author

ok, that did not work, because I messed up with dependencies.

@tkrishtop
Copy link
Contributor Author

check workload operator-sdk

@dcibot
Copy link
Collaborator

dcibot commented Oct 19, 2023

@tkrishtop tkrishtop force-pushed the expiration_operator_sdk branch 2 times, most recently from e9ccadd to 24c8138 Compare October 19, 2023 17:19
@tkrishtop
Copy link
Contributor Author

check workload operator-sdk

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/eea453a73cb24dbc8734270777e3bc6b

✔️ dci-rpm-build-el8 SUCCESS in 3m 46s
✔️ dci-rpm-build-el9 SUCCESS in 3m 18s

@dcibot
Copy link
Collaborator

dcibot commented Oct 19, 2023

@tkrishtop
Copy link
Contributor Author

tkrishtop commented Oct 19, 2023 •
edited
Loading

The expiration label was added
image

The overall job failed because podman_image module does not sync fast enough, and thinks that image is still used by a pod. The problem is that the pod is already deleted and its namespace as well. Going to replace podman_image with podman rmi -f to fix the issue.

@tkrishtop
Copy link
Contributor Author

check workload operator-sdk

@tkrishtop tkrishtop changed the title Add 2w expiration to tmp operator-sdk images Add 1d expiration to tmp operator-sdk images Oct 19, 2023
@dcibot
Copy link
Collaborator

dcibot commented Oct 19, 2023

@softwarefactory-project-zuul
Copy link

Build failed.
https://softwarefactory-project.io/zuul/t/local/buildset/0c21a6734a40480e98a0137a20e724ab

❌ dci-rpm-build-el8 TIMED_OUT in 30m 23s
✔️ dci-rpm-build-el9 SUCCESS in 2m 58s

betoredhat
betoredhat approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@betoredhat betoredhat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I see the expiration dates in Quay.

@tkrishtop
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/1e57ecc094784009b6e3db6207873488

✔️ dci-rpm-build-el8 SUCCESS in 3m 31s
✔️ dci-rpm-build-el9 SUCCESS in 2m 50s

@tkrishtop tkrishtop merged commit 347dd1d into main Oct 19, 2023
@tonyskapunk tonyskapunk deleted the expiration_operator_sdk branch October 20, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betoredhat betoredhat betoredhat approved these changes

@manurodriguez manurodriguez manurodriguez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tkrishtop @dcibot @manurodriguez @betoredhat