Add async pubsub manager. #1393
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nihohit
force-pushed
the
shachar/pubsub-manager
branch
3 times, most recently
from
dd4444d to
7c9deea
Compare
nihohit
force-pushed
the
shachar/pubsub-manager
branch
2 times, most recently
from
026d6fa to
7ede7f9
Compare
altanozlu
reviewed
Dec 5, 2024
|
|
||
| /// The configuration for reconnect mechanism and request timing for the [PubSubManager] | ||
| #[derive(Clone, Debug)] | ||
| pub struct PubsubManagerConfig { |
There was a problem hiding this comment.
not directly related to this PR but with PubsubManagerConfig change, there will be 3 different retry configuration in the crate, maybe later on they can merged or share things ?
redis/src/aio/pubsub_manager.rs
Outdated
| let packed_cmd = cmd.get_packed_command(); | ||
| async move { sink.send_recv(packed_cmd).await } | ||
| }); | ||
| // TODO - should we handle errors better than just failing? how? |
There was a problem hiding this comment.
Currently this PubSubManager only accepts PSUBSCRIBE,SUBSCRIBE and if those channels were able to successfully subscribe before there should be no problem reconnecting again, except some network issues etc. which retrying again feels safer imho.
There was a problem hiding this comment.
you're right. clarified the docs.
nihohit
force-pushed
the
shachar/pubsub-manager
branch
from
7ede7f9 to
4f7a756
Compare
A connection manager for pubsub.
nihohit
force-pushed
the
shachar/pubsub-manager
branch
from
4f7a756 to
9ca9a39
Compare
|
I'm having a hard time stabilizing this, so this probably won't make it into 0.28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A connection manager for pubsub.
Based over #1392 & #1341