-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Lua os library section #2671
Conversation
👷 Deploy request for redis-doc pending review.Visit the deploys page to approve it
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I wonder why the other date and time functions os.date, os.time and os.timediff were not exposed. Apart from those, we now seem to allow all standard library functions except the ones that access the file system and IO. I wasn't involved in the original PR though.
@zuiderkwast At first, i wondered whether to expose like o.date and similar non-dangerous Lua api as well. |
We expose the other standard libraries. For those who know Lua from before, they might assume that all standard library functions are available (except the dangerous ones). But I have no strong opinion. |
in redis/redis#12971 we expose a new Lua os api
os.clock()
.