Enforce formatting #95
Conversation
| self.build_account_map() | ||
|
|
||
| self.initialized = True | ||
|
|
||
| def build_account_map(self): | ||
| # map transaction types to target posting accounts | ||
| self.target_account_map = { | ||
| "buymf": self.config['cash_account'], |
There was a problem hiding this comment.
Is there a way to have these be left untouched? It's much more readable the way it currently is IMHO. There are several of this type of block.
| @@ -34,6 +34,4 @@ def get_balance_statement(self, file=None): | |||
|
|
|||
| date = self.get_balance_assertion_date() | |||
| if date: | |||
| yield banking.Balance( | |||
There was a problem hiding this comment.
Could these types of cases be excluded? Perhaps by increasing line width? IMHO, the formatted version is less readable here.
|
Hello there, thanks for the PR! I think this is in general a good idea, and in particular helpful to keep contributions from multiple users consistent. However, it does seem to reduce readability in a few cases. I quickly highlighted a couple patterns, there are probably a few others. If you're familiar with ruff and its options, it'd be great if you could help figure out those cases at least, and I'd be happy to take it in. Thanks again! |
|
I did a bit more digging and the option set is pretty limited. The ruff formatter pretty much matches black which intentionally gives you very few options to change so all code formatted with it should look the same. For specific cases this can be done: # fmt: off
code_here()
...
#fmt: onI would argue consistency across the board is better but let me know if you want formatting disabled on the sections you pointed out. |
|
Thanks for looking this up. You make a good point, and I agree overall. I still feel like f you're okay making the change to exclude those blocks alone, I'd be happy to take it in. Thank you! |
ranebrown
force-pushed
the
Enforce_Formatting
branch
from
facce82 to
142c5f6
Compare
|
Made a few more changes:
|
|
Looks great, I appreciate the PR and the changes! This was long needed. Merged. Thank you! |
Adds a job to check formatting and formats all existing files with ruff.
Config options if you want anything changed from the defaults.