Refactor Select Coaching Session Component #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhodapp
added this to the 0.7 - Set/change the current user's session organization and coaching relationship milestone
…hing else in the application relies on "objectId"
jhodapp
commented
Oct 5, 2024
| const TO_DATE = DateTime.now().plus({ month: 1 }).toISODate(); | ||
|
|
||
| const handleOrganizationSelection = (id: Id) => { | ||
| fetchOrganization(id) |
There was a problem hiding this comment.
@qafui This is what I'm referring to, can we/should we rework fetchOrganization to use your use-api-data in this PR, or do that across the board in a second fast-follower PR? I'm open to either option.
jhodapp
commented
Oct 5, 2024
| }; | ||
|
|
||
| const handleRelationshipSelection = (id: Id) => { | ||
| fetchCoachingRelationshipWithUserNames(organization.id, id) |
There was a problem hiding this comment.
@qafui Same thing here...
jhodapp
commented
Oct 5, 2024
| }; | ||
|
|
||
| const handleSessionSelection = (id: Id) => { | ||
| fetchCoachingSessions(relationship.id) |
jhodapp
commented
Oct 7, 2024
| @@ -20,7 +20,7 @@ interface AppState { | |||
| coachingRelationship: CoachingRelationshipWithUserNames; | |||
| } | |||
|
|
|||
| interface AppStateActions { | |||
| export interface AppStateActions { | |||
There was a problem hiding this comment.
Suggested change
| export interface AppStateActions { | |
| interface AppStateActions { |
@qafui this is meant to be private to AppStateStore, any reason to broaden its scope?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
useSWRhook from theswrlibrary as a wrapper around a global fetcher hook (useApiData). It allows any component to access the data it needs for rendering dynamic values from the API.A dashboard component is refactored to use the new hook to fetch data for conditionally rendered select components and a button. The
JoinCoachingSessioncomponent allows a user to select an organization, a coaching relationship and a session and join the session with a button click.Changes
JoinCoachingSessioncomponent responsible for setting organization, relationship and session IDs in the state tree.Screenshots / Videos Showing UI Changes (if applicable)
Testing Strategy
Login and attempt to join a session using the component illustrated in the image
Concerns
dynamic-api-selectcomponent should be separated into its own component.