Add two new CLI flags to set the host side TCP interface and port #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… listen on for incoming client connections. Sets the default port to 4000
jhodapp
force-pushed
the
change_default_tcp_server_port_to_4000
branch
from
e11fa07 to
d007f0c
Compare
calebbourg
approved these changes
Nov 18, 2023
| @@ -14,16 +14,16 @@ mod router; | |||
|
|
|||
| pub async fn init_server(app_state: AppState) -> Result<()> { | |||
| // These will probably come from app_state.config (command line) | |||
| let host = "127.0.0.1"; | |||
| let port = 3000; | |||
| let host = app_state.config.interface.as_ref().unwrap(); | |||
There was a problem hiding this comment.
Curious why we need the as_ref here?
There was a problem hiding this comment.
The unwrap() consumes the value otherwise which causes rustc to complain about the ownership move farther down in the code on line 27.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds two new CLI flags to set the host side TCP interface and port to listen on for incoming client connections. Sets the default port to 4000.
GitHub Issue: N/A
Changes
-iasStringto set the host side TCP interface address-pasu16to set the host side TCP portTesting Strategy
Run the following:
-->
cargo run -- -t 2 -p 3000 -i 127.0.0.1and observe that the server outputs an INFO log line showing:
-->
[INFO] Server starting... listening for connections on http://127.0.0.1:3000Concerns
None