-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continued authz #81
Open
calebbourg
wants to merge
19
commits into
main
Choose a base branch
from
continued_authz
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Continued authz #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebbourg
force-pushed
the
continued_authz
branch
from
December 9, 2024 16:01
2940ce8
to
1f031b1
Compare
also fixes test
There is a lot of duplicated code here. The plan is to defer refactoring for now and take a look at a better error handling system.
calebbourg
force-pushed
the
continued_authz
branch
from
December 12, 2024 13:37
1f031b1
to
06c401f
Compare
jhodapp
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A great start, I'm looking forward to building on top of this!
…rams. Also accept a list of CORS allowed origin URLs instead of hardcoding them.
…he Rust backend expects
…actor_platform_rs binary
…tions are set and passed from the backend/docker-compose.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds Authorization plumbing and functions for
index
actions.There's a good amount of duplicated code. I think I'm at a point where I'd like to audit and re-think our error handling a bit. Probably use an existing crate. My thought is that it will be much easier to refactor some of this authorization stuff to remove the duplication if I take a step back and improve on how errors are propagated through our abstraction layers.
The plan would be something like this:
Testing Strategy
valid coaching_relationship_id