Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overarching goals and actions not saving #89

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Fix overarching goals and actions not saving #89

merged 2 commits into from
Dec 16, 2024

Conversation

jhodapp
Copy link
Member

@jhodapp jhodapp commented Dec 16, 2024 •
edited
Loading

Description

This PR fixes overarching goals and actions not saving by put custom enum type status is in the refactor_platform DB schema instead of the public default one.

Note PR #88 must land before this one does.

GitHub Issue: None

Changes

  • Fix overarching goals and actions not saving

Testing Strategy

  1. Log in and join a session
  2. Ensure that both an OverarchingGoal and at least 1 Action can be created successfully

Concerns

None

@jhodapp jhodapp added the bug fix Contains a fix to a known bug label Dec 16, 2024
@jhodapp jhodapp added this to the 1.0-rc1 milestone Dec 16, 2024
@jhodapp jhodapp requested a review from calebbourg December 16, 2024 05:47
@jhodapp jhodapp self-assigned this Dec 16, 2024
calebbourg
calebbourg approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@calebbourg calebbourg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very interesting. Nice catch.

@jhodapp jhodapp merged commit 1c75ae4 into main Dec 16, 2024
4 checks passed
@jhodapp jhodapp deleted the fix_overarching_goals_and_actions_not_saving branch December 16, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebbourg calebbourg calebbourg approved these changes

Assignees

@jhodapp jhodapp

Labels
bug fix Contains a fix to a known bug
Projects
Refactor Coaching Platform
Status: ✅ Done
Milestone
1.0-rc1
Development

Successfully merging this pull request may close these issues.
2 participants
@jhodapp @calebbourg